refactor(Heading): update component to CSS Modules #4819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 61e16dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
langermank
approved these changes
Aug 7, 2024
jonrohan
reviewed
Aug 7, 2024
jonrohan
approved these changes
Aug 14, 2024
jonrohan
added a commit
that referenced
this pull request
Aug 15, 2024
* refactor(Heading): update component to CSS Modules * test(e2e): add feature flags for Heading test * chore: fix stylelint errors * test(e2e): update snapshots for Heading * refactor(Heading): incorporate variant features into CSS Modules * chore: add changeset * test(e2e): remove theme testing * Fix props here * Remove examples/nextjs * Clean up css --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com> Co-authored-by: Jon Rohan <yes@jonrohan.codes>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/github/primer/issues/3716
Changelog
New
Changed
Headingto use CSS ModulesRemoved
Rollout strategy