Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgressBar: Remove aria-busy from ProgressBar #4841

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

TylerJDev
Copy link
Contributor

@TylerJDev TylerJDev commented Aug 12, 2024

Closes https://github.com/github/primer/issues/3360

It was noted that the usage of aria-busy on role="progressbar" is unnecessary, as it is intended for a section of the page that is currently being updated, signaling to screen readers that they should wait before announcing the content.

This PR removes the attribute from ProgressBar.

Changelog

New

Removed

  • Removed aria-busy from ProgressBar

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Aug 12, 2024

🦋 Changeset detected

Latest commit: 3bf029a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 12, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.04 KB (-0.17% 🔽)
packages/react/dist/browser.umd.js 96.44 KB (-0.02% 🔽)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/337288

@TylerJDev TylerJDev marked this pull request as ready for review August 13, 2024 13:46
@TylerJDev TylerJDev requested a review from a team as a code owner August 13, 2024 13:46
@TylerJDev TylerJDev changed the title Remove aria-busy from ProgressBar ProgressBar: Remove aria-busy from ProgressBar Aug 13, 2024
@TylerJDev TylerJDev added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit f3b08df Aug 14, 2024
32 checks passed
@TylerJDev TylerJDev deleted the tylerjdev/remove-aria-busy branch August 14, 2024 19:15
@primer primer bot mentioned this pull request Aug 14, 2024
jonrohan pushed a commit that referenced this pull request Aug 15, 2024
* Update snapshots

* Add changeset
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants