Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ButtonBase): To use CSS modules behind the feature flag #4940

Merged
merged 36 commits into from
Sep 13, 2024
Merged
Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
484eb6d
copy
langermank Sep 9, 2024
8873d34
setting
langermank Sep 9, 2024
66464e0
Create olive-donkeys-exercise.md
langermank Sep 9, 2024
fa2afef
test(vrt): update snapshots
langermank Sep 9, 2024
5bd420e
update tests
langermank Sep 9, 2024
122521b
we got this
langermank Sep 9, 2024
5935b68
vrt dont lie
langermank Sep 9, 2024
b06add2
Merge branch 'main' into button-branch-was-cursed
langermank Sep 9, 2024
fdb4f57
test(vrt): update snapshots
langermank Sep 9, 2024
323a477
more fixes
langermank Sep 9, 2024
a35016b
Merge branch 'main' into button-branch-was-cursed
langermank Sep 9, 2024
101c2a5
Merge branch 'main' into button-branch-was-cursed
langermank Sep 10, 2024
7dd7aa4
fix focus outline
langermank Sep 10, 2024
7c30d4b
where where where
langermank Sep 11, 2024
d2add57
fix nesting
langermank Sep 11, 2024
7c950c8
Merge branch 'main' into button-branch-was-cursed
langermank Sep 11, 2024
d657b65
fix nesting i think
langermank Sep 11, 2024
d1562e8
test vrt
langermank Sep 12, 2024
c05d4c7
cleanup
langermank Sep 12, 2024
ce5672a
important...
langermank Sep 12, 2024
75406cd
Merge branch 'main' into button-branch-was-cursed
langermank Sep 12, 2024
e4ba5e1
try reverting this change?
langermank Sep 12, 2024
d6474d5
try resetting stories
langermank Sep 12, 2024
47c67d0
reset from main
langermank Sep 12, 2024
0a8c4ce
fix classname on iconbutton
langermank Sep 13, 2024
91e7541
try no calc
langermank Sep 13, 2024
7347962
more digits??
langermank Sep 13, 2024
49a6b59
test(vrt): update snapshots
langermank Sep 13, 2024
0faa87d
lets goooooo
langermank Sep 13, 2024
59a39ca
Merge branch 'button-branch-was-cursed' of https://github.com/primer/…
langermank Sep 13, 2024
dffc4c3
Merge branch 'main' into button-branch-was-cursed
langermank Sep 13, 2024
0f81dd7
oops
langermank Sep 13, 2024
b82f00c
reset
langermank Sep 13, 2024
3e5ea1b
Revert "reset"
langermank Sep 13, 2024
c890dba
reset
langermank Sep 13, 2024
923daae
test(vrt): update snapshots
langermank Sep 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/olive-donkeys-exercise.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": major
---

Refactor ButtonBase component to use CSS modules behine flag
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 7 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,13 @@
"[typescriptreact]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[postcss]": {
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.formatOnSave": true,
"editor.codeActionsOnSave": {
"source.fixAll.stylelint": "explicit"
}
},
"json.schemas": [
{
"fileMatch": ["*.docs.json"],
Expand Down
Loading
Loading