Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving Heading feature flag from staff ship to ga ship #4971

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Moving Heading feature flag from staff ship to ga ship #4971

merged 2 commits into from
Sep 17, 2024

Conversation

jonrohan
Copy link
Member

Part of https://github.com/github/primer/issues/3716

Changelog

Changed

The feature flag for Heading changed from primer_react_css_modules_staff to primer_react_css_modules_ga

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

@jonrohan jonrohan requested a review from a team as a code owner September 16, 2024 19:16
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 274deaa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.5 KB (+0.03% 🔺)
packages/react/dist/browser.umd.js 97.65 KB (-0.16% 🔽)

@jonrohan jonrohan changed the title Moving Heading feature flag from staff ship to team ship Moving Heading feature flag from staff ship to ga ship Sep 16, 2024
siddharthkp
siddharthkp approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay exciting!

@jonrohan jonrohan added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit ff56b04 Sep 17, 2024
33 checks passed
@jonrohan jonrohan deleted the css_module_ga_heading branch September 17, 2024 16:39
@primer primer bot mentioned this pull request Sep 17, 2024
Merged
@broccolinisoup broccolinisoup mentioned this pull request Sep 19, 2024
Closed
13 tasks
TylerJDev pushed a commit that referenced this pull request Sep 23, 2024
@jonrohan @TylerJDev
Moving Heading feature flag from staff ship to ga ship (#4971)
1d5e931 
* Moving Heading component to ga flag

* Create nice-moles-know.md
@primer primer bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharthkp siddharthkp siddharthkp approved these changes

Assignees
No one assigned
Labels
staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @siddharthkp