Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Label component feature flag from primer_react_css_modules_staff to primer_react_css_modules_ga #5022

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Move Label component feature flag from primer_react_css_modules_staff to primer_react_css_modules_ga #5022

merged 2 commits into from
Sep 25, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Sep 24, 2024 •
edited
Loading

Changelog

Changed

Move Label component feature flag from primer_react_css_modules_staff to primer_react_css_modules_ga

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 81cfabd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 24, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.24 KB (-0.02% 🔽)
packages/react/dist/browser.umd.js 98.47 KB (-0.11% 🔽)

@jonrohan jonrohan marked this pull request as ready for review September 24, 2024 22:16
@jonrohan jonrohan requested a review from a team as a code owner September 24, 2024 22:16
@jonrohan jonrohan added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit 4395d16 Sep 25, 2024
30 of 31 checks passed
@jonrohan jonrohan deleted the css_modules_move_label_to_ga branch September 25, 2024 16:49
@primer primer bot mentioned this pull request Sep 25, 2024
Merged
@primer primer bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@keithamus keithamus Awaiting requested review from keithamus keithamus is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @joshblack