Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ButtonGroup): Move ButtonGroup CSS module feature flag from staff to ga #5281

Merged
merged 2 commits into from
Nov 14, 2024
Merged

chore(ButtonGroup): Move ButtonGroup CSS module feature flag from staff to ga #5281

merged 2 commits into from
Nov 14, 2024

Conversation

jonrohan
Copy link
Member

Changelog

New

Changed

chore(ButtonGroup): Move ButtonGroup CSS module feature flag from staff to ga

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@jonrohan jonrohan requested a review from a team as a code owner November 13, 2024 22:53
@github-actions github-actions bot added the staff Author is a staff member label Nov 13, 2024
@jonrohan jonrohan removed the request for review from broccolinisoup November 13, 2024 22:54
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 13, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: ffb7b75

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.67 KB (-0.13% 🔽)
packages/react/dist/browser.umd.js 99.07 KB (+0.08% 🔺)

francinelucca
francinelucca approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@jonrohan jonrohan added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit b8e138e Nov 14, 2024
43 checks passed
@jonrohan jonrohan deleted the css_modules_buttongroup_ga branch November 14, 2024 16:28
@primer primer bot mentioned this pull request Nov 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francinelucca francinelucca francinelucca approved these changes

@TylerJDev TylerJDev Awaiting requested review from TylerJDev

Assignees
No one assigned
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @francinelucca