Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Header): Remove CSS modules feature flag from Header #5510

Merged
merged 6 commits into from
Feb 14, 2025
Merged

chore(Header): Remove CSS modules feature flag from Header #5510

merged 6 commits into from
Feb 14, 2025

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Jan 8, 2025

Changelog

New

Changed

Removed

Remove CSS modules feature flag from Header

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 8, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: d65af11

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Jan 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 8, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5510 January 8, 2025 23:43 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.53 KB (-0.16% 🔽)
packages/react/dist/browser.umd.js 105.88 KB (-0.13% 🔽)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/362515

@github-actions github-actions bot temporarily deployed to storybook-preview-5510 February 13, 2025 18:05 Inactive
@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Feb 13, 2025
@jonrohan jonrohan marked this pull request as ready for review February 13, 2025 20:03
@jonrohan jonrohan requested a review from a team as a code owner February 13, 2025 20:03
@jonrohan jonrohan requested review from mperrotti and francinelucca and removed request for mperrotti February 13, 2025 20:03
@jonrohan jonrohan enabled auto-merge February 13, 2025 20:26
@github-actions github-actions bot temporarily deployed to storybook-preview-5510 February 13, 2025 20:32 Inactive
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 13, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot requested a deployment to storybook-preview-5510 February 13, 2025 20:58 Abandoned
francinelucca
francinelucca approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@jonrohan jonrohan added this pull request to the merge queue Feb 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 14, 2025
@jonrohan jonrohan added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit 37a91b5 Feb 14, 2025
44 checks passed
@jonrohan jonrohan deleted the css_modules_remove_header branch February 14, 2025 17:40
@primer primer bot mentioned this pull request Feb 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francinelucca francinelucca francinelucca approved these changes

Assignees
No one assigned
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @francinelucca