Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add landing page and upload vrt/aat reports to GitHub Pages #5613

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Add landing page and upload vrt/aat reports to GitHub Pages #5613

merged 3 commits into from
Jan 28, 2025

Conversation

hussam-i-am
Copy link
Contributor

@hussam-i-am hussam-i-am commented Jan 28, 2025 •
edited
Loading

Same as #5609, which was reverted, but with the additional change of 1575592 that structures the workflows so they can match the to-be-updated requred workflows for non-pull_request runs

Required builds settings

@hussam-i-am hussam-i-am requested a review from a team as a code owner January 28, 2025 12:24
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 30c7749

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hussam-i-am hussam-i-am self-assigned this Jan 28, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.45 KB (0%)
packages/react/dist/browser.umd.js 104.83 KB (0%)

@hussam-i-am hussam-i-am changed the title Revert "Revert "Add landing page and upload vrt/aat reports to GitHub Pages"" Add landing page and upload vrt/aat reports to GitHub Pages Jan 28, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5613 January 28, 2025 12:35 Inactive
@github-actions github-actions bot requested a deployment to storybook-preview-5613 January 28, 2025 13:01 Abandoned
@jonrohan jonrohan added the skip changeset This change does not need a changelog label Jan 28, 2025
@hussam-i-am hussam-i-am enabled auto-merge January 28, 2025 17:19
@hussam-i-am hussam-i-am disabled auto-merge January 28, 2025 17:20
@jonrohan jonrohan enabled auto-merge January 28, 2025 17:20
@jonrohan jonrohan added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 50ef6a4 Jan 28, 2025
44 of 45 checks passed
@jonrohan jonrohan deleted the revert-5611-revert-5609-hussam-i-am/pr-preview-page branch January 28, 2025 17:25
joshblack added a commit that referenced this pull request Feb 3, 2025
@joshblack
Revert "Add landing page and upload vrt/aat reports to GitHub Pages (#…
3ecec4f 
…5613)"

This reverts commit 50ef6a4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@francinelucca francinelucca Awaiting requested review from francinelucca francinelucca is a code owner automatically assigned from primer/engineer-reviewers

Assignees

@hussam-i-am hussam-i-am

Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hussam-i-am @jonrohan