Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(ActionList.Item): Remove styles from enabled ActionList.Item #5657

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Feb 4, 2025

Closes https://github.com/github/primer/issues/4745
Closes https://github.com/github/primer/issues/4752

Changelog

New

Changed

We discovered that the ActionList.Item was applying the old styles from styled components and the new CSS modules classnames whenever a sxProp was being passed in. This was causing some visual bugs in production. Removing the extra style here fixes the issue

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@langermank langermank changed the title remove merge styles Remove styles from enabled ActionList.Item Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.42 KB (+0.05% 🔺)
packages/react/dist/browser.umd.js 105.82 KB (-0.01% 🔽)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/360875

Copy link

changeset-bot bot commented Feb 4, 2025

🦋 Changeset detected

Latest commit: 707fdaa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@langermank langermank marked this pull request as ready for review February 4, 2025 22:51
@langermank langermank requested a review from a team as a code owner February 4, 2025 22:51
@langermank langermank requested a review from joshblack February 4, 2025 22:51
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to ask, does style need to be added anywhere else when sx is passed since it's no longer being merged?

@jonrohan
Copy link
Member

jonrohan commented Feb 4, 2025

Just wanted to ask, does style need to be added anywhere else when sx is passed since it's no longer being merged?

Style shouldn't have been included here, it was mistakenly added when the classes takes care of the styles. We found we were applying styled components styles and CSS modules styles in this case

@jonrohan jonrohan changed the title Remove styles from enabled ActionList.Item bugfix(ActionList.Item): Remove styles from enabled ActionList.Item Feb 4, 2025
@langermank langermank added this pull request to the merge queue Feb 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 4, 2025
@langermank langermank added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit de4fc48 Feb 5, 2025
47 checks passed
@langermank langermank deleted the actionlist-sxprop-leak branch February 5, 2025 00:13
@primer primer bot mentioned this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants