-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix(ActionList.Item): Remove styles
from enabled
ActionList.Item
#5657
Conversation
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
styles
from enabled
ActionList.Item
size-limit report 📦
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/360875 |
🦋 Changeset detectedLatest commit: 707fdaa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to ask, does style
need to be added anywhere else when sx
is passed since it's no longer being merged?
Style shouldn't have been included here, it was mistakenly added when the classes takes care of the styles. We found we were applying styled components styles and CSS modules styles in this case |
styles
from enabled
ActionList.Itemstyles
from enabled
ActionList.Item
Closes https://github.com/github/primer/issues/4745
Closes https://github.com/github/primer/issues/4752
Changelog
New
Changed
We discovered that the
ActionList.Item
was applying the oldstyles
from styled components and the new CSS modules classnames whenever a sxProp was being passed in. This was causing some visual bugs in production. Removing the extrastyle
here fixes the issueRemoved
Rollout strategy
Testing & Reviewing
Merge checklist