Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As part of the TypeScript refactor, we're rewriting component test files in TypeScript. However, we never type check these test files during CI. So test files with type errors could still pass CI and be merged into the
main
branch, causing errors in consuming applications.For example, if the type definition for the
Box
component is incorrect, we might not know about the error until a consuming application usesBox
and encounters the error. If we type check theBox
test file during CI, we'd surface the error before merging the PR.Solution
This PR updates
tsconfig.json
to include test files when type checking and generating type definition files.Impact
If any test files contain type errors, CI will fail. Since our tests (should) resemble the way components are used, we can catch type errors before they reach consumers.