Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Pagehead to TypeScript #977

Merged
merged 3 commits into from
Jan 21, 2021
Merged

Migrate Pagehead to TypeScript #977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce217ad
Pagehead.js → Pagehead.tsx
colebemis Jan 21, 2021
e83af95
Merge branch 'main' into cb/ts-pagehead
colebemis Jan 21, 2021
755a1a5
Add changeset
colebemis Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slimy-rats-mix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/components": patch
---

Migrate `Pagehead` to TypeScript
7 changes: 4 additions & 3 deletions src/Pagehead.js → src/Pagehead.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import PropTypes from 'prop-types'
import styled from 'styled-components'
import {COMMON, get} from './constants'
import {COMMON, get, SystemCommonProps} from './constants'
import sx, {SxProp} from './sx'
import theme from './theme'
import sx from './sx'

const Pagehead = styled.div`
const Pagehead = styled.div<SystemCommonProps & SxProp>`
position: relative;
padding-top: ${get('space.4')};
padding-bottom: ${get('space.4')};
Expand All @@ -24,4 +24,5 @@ Pagehead.propTypes = {
...sx.propTypes
}

export type PageheadProps = React.ComponentProps<typeof Pagehead>
export default Pagehead
0 src/__tests__/Pagehead.js → src/__tests__/Pagehead.tsx
View file
Open in desktop
File renamed without changes.
0 src/__tests__/__snapshots__/Pagehead.js.snap → ...__tests__/__snapshots__/Pagehead.tsx.snap
View file
Open in desktop
File renamed without changes.