Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Position to TypeScript #998

Merged
merged 5 commits into from
Feb 8, 2021
Merged

Migrate Position to TypeScript #998

merged 5 commits into from
Feb 8, 2021

Conversation

colebemis
Copy link
Contributor

@colebemis colebemis commented Jan 28, 2021

This PR migrates the Position component to TypeScript as part of the TypeScript refactor.

@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2021

🦋 Changeset detected

Latest commit: 77f9678

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/ec9dbycfo
✅ Preview: https://primer-components-git-cb-ts-position.primer.vercel.app

@colebemis colebemis mentioned this pull request Jan 28, 2021
53 tasks
@vercel vercel bot temporarily deployed to Preview February 8, 2021 22:42 Inactive
@colebemis colebemis marked this pull request as ready for review February 8, 2021 22:43
@vercel vercel bot temporarily deployed to Preview February 8, 2021 22:45 Inactive
@vercel vercel bot temporarily deployed to Preview February 8, 2021 23:08 Inactive
Copy link
Contributor

@VanAnderson VanAnderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vercel vercel bot temporarily deployed to Preview February 8, 2021 23:56 Inactive
@colebemis colebemis merged commit b6eb246 into main Feb 8, 2021
@colebemis colebemis deleted the cb/ts-position branch February 8, 2021 23:56
@github-actions github-actions bot mentioned this pull request Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants