-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate FormGroup to TypeScript #999
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/im6tylh82 |
This "component as namespace" pattern is difficult to type with styled-components. Does have any ideas on how to type this? @smockle @bscofield @VanAnderson |
Oooh interesting problem! I do know a few ways we could type this; here are two options: |
Found a simple solution to the namespace type issue using export default Object.assign(FormGroup, {Label: FormGroupLabel}) |
This PR migrates the
FormGroup
component to TypeScript as part of the TypeScript refactor.