Fix/strategy lib muldiv #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemlak
requested review from
Alexangelj and
kinrezC
and removed request for
Alexangelj
clemlak
added
📃 contracts
|
One test is still failing, looks like the function we're using the compute the price of a LogNormal pool is rounding in the wrong direction? |
kinrezC
approved these changes
Mar 29, 2024
|
@kinrezC and I discovered a weird behavior in the LogNormal pool, if someone allocates a small amount of token Y (for example 0.77), the price of the pool might change and decrease by 2. This issue is only happening if the total liquidity in the pool is less than 20 WAD and the price is 1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf https://github.com/cantinasec/review-primitive-excalibur/pull/2#discussion_r1541547702 and https://github.com/cantinasec/review-primitive-excalibur/pull/2#discussion_r1541558624.