Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/g3m trading function rounding #101

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Fix/g3m trading function rounding #101

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80bc05e
fix: change rounding in G3M trading function
clemlak Mar 29, 2024
8cb531c
Merge branch 'fix/spearbit-audit' into fix/g3m-trading-function-rounding
clemlak Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/GeometricMean/G3MMath.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ function computeTradingFunction(
uint256 L,
GeometricMeanParams memory params
) pure returns (int256) {
uint256 a = uint256(int256(rX.divWadDown(L)).powWad(int256(params.wX)));
uint256 b = uint256(int256(rY.divWadDown(L)).powWad(int256(params.wY)));
uint256 a = uint256(int256(rX.divWadUp(L)).powWad(int256(params.wX)));
uint256 b = uint256(int256(rY.divWadUp(L)).powWad(int256(params.wY)));

return int256(a.mulWadUp(b)) - int256(1 ether);
}
Expand Down
Loading