Flash swap feature #123
Merged
Flash swap feature #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexangelj
added
💡 feature
|
Do not merge until the compilation is fixed. fighting stack too deep |
clemlak
approved these changes
Apr 10, 2024
clemlak
reviewed
Apr 10, 2024
Comment on lines
+281
to
+286
| uint256 downscaledAmount = | ||
| downscaleUp(state.amountIn, computeScalingFactor(state.tokenIn)); | ||
| uint256 postBalance = ERC20(state.tokenIn).balanceOf(address(this)); | ||
| if (postBalance < preBalance + downscaledAmount) { | ||
| revert InvalidTransfer(); | ||
| } |
There was a problem hiding this comment.
I fixed a small issue here: some amounts were in WAD and some were not.
|
I fixed the stack too deep error, a small issue related to WAD units and added a couple of tests. We should be good now. |
kinrezC
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flash swaps will optimistically send tokens out during swaps before the input tokens are requested. This will enable the output of a swap to be used for payments in other integrated protocols.
Changes:
callbackDataargument toswap(). This argument is passed to the callback() tomsg.sender. If the length of data is0, it will not do the callback and instead use_transferFrom().ISwapCallbackinterface to define the callback function.recipientbefore the input tokens are required/requested.Concerns: