Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/missing constant sum controller #83

Merged
merged 5 commits into from
Mar 25, 2024
Merged

Fix/missing constant sum controller #83

merged 5 commits into from
Mar 25, 2024

Conversation

clemlak
Copy link
Contributor

@clemlak clemlak commented Mar 19, 2024

@clemlak clemlak self-assigned this Mar 19, 2024
@clemlak clemlak added 🔨 audit fix Patching audit findings 📃 contracts Anything related to the DFMM contracts (or strategies) labels Mar 19, 2024
kinrezC
kinrezC reviewed Mar 22, 2024
View reviewed changes
Copy link
Contributor

@kinrezC kinrezC left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a bit strange to me that we'd have a controller here when price isn't a dynamic param. Maybe price should be a dynamic param?

edit: regardless, the price being a dynamic param is outside the scope of this PR, so LGTM

@clemlak clemlak changed the base branch from main to fix/spearbit-audit March 25, 2024 10:08
@clemlak
Copy link
Contributor Author

clemlak commented Mar 25, 2024

Seems a bit strange to me that we'd have a controller here when price isn't a dynamic param. Maybe price should be a dynamic param?

edit: regardless, the price being a dynamic param is outside the scope of this PR, so LGTM

I agree, let's make the price a dynamic parameter too.

@clemlak clemlak merged commit 7e930dc into fix/spearbit-audit Mar 25, 2024
5 checks passed
@clemlak clemlak deleted the fix/missing-constant-sum-controller branch March 25, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexangelj Alexangelj Alexangelj approved these changes

@kinrezC kinrezC kinrezC approved these changes

Assignees

@clemlak clemlak

Labels
🔨 audit fix Patching audit findings 📃 contracts Anything related to the DFMM contracts (or strategies)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clemlak @kinrezC @Alexangelj