Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an optional parameter to Pool.liquidityQuote #11

Closed
zachdt opened this issue Nov 5, 2021 · 0 comments
Closed

Add an optional parameter to Pool.liquidityQuote #11

zachdt opened this issue Nov 5, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@zachdt
Copy link
Contributor

zachdt commented Nov 5, 2021

Right now, liquidityQuote only works for pools with existing liquidity. It should take an optional parameter, new?: bool that references the spot price (initialized in Pool constructor) to provide a liquidityQuote for a new pool.

If this isn't implemented, we will use a helper function in the interface. Might as well include that functionality in the SDK.
@zachdt zachdt added the enhancement New feature or request label Nov 5, 2021
Alexangelj added a commit that referenced this issue Nov 8, 2021
@Alexangelj
feat(#11): adds a fresh argument to liquidityQuote
043400c
Alexangelj added a commit that referenced this issue Nov 8, 2021
@Alexangelj
Merge pull request #12 from primitivefinance/feat/liquidity-quote-new
617d6ea 
feat(#11): adds a fresh argument to liquidityQuote
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zachdt @Alexangelj