Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct some typings and a incorrect function call #186

Merged
merged 2 commits into from
Jul 22, 2024
Merged

fix: correct some typings and a incorrect function call #186

merged 2 commits into from
Jul 22, 2024

Conversation

yuxqiu
Copy link
Contributor

@yuxqiu yuxqiu commented Jul 21, 2024

What does this implement/fix?

  1. Fix some incorrect typings in test_spec.py (TestSpec class and get_test_specs_from_dataset function)
  2. Fix an incorrect function call to find_dependent_images in get_env_configs_to_build. We should pass client and image_name to the function rather than env_image.

@john-b-yang
Copy link
Collaborator

Thanks so much for these fixes @yuxqiu, appreciate it! I have reviewed it and it checks out.

@john-b-yang john-b-yang merged commit f3dba57 into princeton-nlp:main Jul 22, 2024
1 check passed
@yuxqiu yuxqiu deleted the typings branch July 22, 2024 04:49
sreekarmolakalapalli pushed a commit to Modelcode-ai/SWE-bench that referenced this pull request Aug 14, 2024
@john-b-yang
Merge pull request princeton-nlp#186 from yuxqiu/typings
8f38fb0 
fix: correct some typings and a incorrect function call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuxqiu @john-b-yang