Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove incorrect exec_run calls #189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yuxqiu
Copy link
Contributor

@yuxqiu yuxqiu commented Jul 28, 2024

What does this implement/fix?

Remove some unnecessary/incorrect exec_run calls in copy_too_container.

According to the docker documentation, put_archive will “insert a file or folder in this container using a tar archive as source“. In other words, it does not simply copy the tar into the container. Instead, it will extract all the files in the tar directly to a destination in the container.

Therefore, we should remove unnecessary/incorrect calls to tar and rm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant