Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few MDX renderer problems #55

Closed
wants to merge 2 commits into from
Closed

Fix a few MDX renderer problems #55

wants to merge 2 commits into from

Conversation

imchairmanm
Copy link
Contributor

There were a few issues preventing the repo from building correctly:

  1. Although it says this was resolved, the version of Gatsby we're using
    doesn't seem to have this fix: Comments without new line above result in babel error mdx-js/mdx#244
    Adding a new line was enough to make it work
  2. There were a few unterminated SwitchTech instances.

imchairmanm and others added 2 commits March 29, 2020 16:18
There were a few issues preventing the repo from building correctly:

1. Although it says this was resolved, the version of Gatsby we're using
doesn't seem to have this fix: mdx-js/mdx#244
Adding a new line was enough to make it work
2. There were a few unterminated `SwitchTech` instances.
@nikolasburk
Copy link
Member

Thanks a lot for catching those Justin, I just had resolved them this morning as well 🙂 (before I saw this PR 😑 )

@imchairmanm imchairmanm deleted the fix_build branch April 8, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments without new line above result in babel error
2 participants