Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "patch" for extension versioning #114

Closed
divyenduz opened this issue Apr 24, 2020 · 1 comment · Fixed by #115
Closed

Use "patch" for extension versioning #114

divyenduz opened this issue Apr 24, 2020 · 1 comment · Fixed by #115
Assignees
Labels
bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. topic: automation
Milestone

Comments

@divyenduz
Copy link

divyenduz commented Apr 24, 2020

With this PR #109, we implemented required changes for #93

But because of the marketplace limitations, it is not yet possible to have strings in a version: microsoft/vscode-vsce#148

Because of this release CI is broken right now and we are figuring out a way to translate Prisma version to VSCode extension version. Also supporting independent extension releases with the process

While we work that out, we can use the "patch" strategy for extension versioning in the CI. This is the approach we were using before #109 was merged

Essentially, for every release, simply patch the version by one number independent of the Prisma version

Examples:

  • Prisma extension goes from 0.0.32 (current) -> 0.0.33 -> 0.0.34 and so on irrespective of why a release happened

  • Prisma Dev extension goes from 0.0.1 (current) -> 0.0.2 -> 0.0.3 and so on irrespective of why a release happened

  • If we want to intervene the versions for any reason, we can manually push say 0.0.x and the next patch will automatically be 0.0.x+1

@divyenduz divyenduz added this to the Beta 4 milestone Apr 24, 2020
@janpio janpio added bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. team/other topic: automation labels Apr 24, 2020
@divyenduz
Copy link
Author

Note: Since, I can't get the published extension version from marketplace. I need to write that into a file again, one for each channel (say prisma_version_stable, prisma_version_unstable).

We only commit from the unstable channel but we have to commit this version file also from the stable channel.

divyenduz pushed a commit that referenced this issue Apr 27, 2020
- applies to both stable and unstable channels
- fixes #114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. topic: automation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants