test(query-engine): fix some PlanetScale tests #4909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #4909 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
|
I'm merging this PR, as it's self-contained, is green on the CI, and only touches a couple of tests. |
SevInf
reviewed
Jun 7, 2024
| r#"mutation{createOnePost(data:{id: 2, user_id:2, user_age: 2}){id, user_id, user_age, User{id}}}"#, | ||
| 2003 | ||
| ); | ||
| // Foreign key violation, which doesn't happen on PlanetScale. |
There was a problem hiding this comment.
Because foreign keys are disabled by default on PlanetScale. Plus, our PlanetScale simulator lacks the ability to turn foreign key violations on
There was a problem hiding this comment.
Could we add this to the comment?
Also, shouldn't we have an emulated error in this case?
This was referenced Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes: