fix: strip traceparent comment from info_span #5078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #5078 will not alter performanceComparing Summary
|
aqrln
reviewed
Dec 9, 2024
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| let query = self | ||
| .0 | ||
| .split_once("/* traceparent=") |
There was a problem hiding this comment.
An edge case but: what if /* traceparent= is used in a query (e.g. in a string literal)? If it's a raw query, it's not necessarily going to be a parameter and could be hardcoded. Could we check that we are matching a comment at the very end of the query (maybe a regex is fine)?
There was a problem hiding this comment.
I've added a check for an end of comment followed by an end of input after the traceparent and an additional test
There was a problem hiding this comment.
oh dang the test wasnt asserting on logs_contain 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/prisma/team-orm/issues/1382
Fixes: prisma/prisma#24375