Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(psl): add support for multi-line comments #5083

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Dec 12, 2024

This PR introduces support for multi-line comments in schema.prisma, using the /* ... */ conventional syntax.
It expands prisma validate, prisma format, and other commands that rely on those two internal functionality.

This PR closes prisma/prisma#4474, but it requires an additional PR in prisma/language-tools.

@jkomyno jkomyno requested a review from a team as a code owner December 12, 2024 10:58
@jkomyno jkomyno requested review from jacek-prisma and removed request for a team December 12, 2024 10:58
@jkomyno
Copy link
Contributor Author

jkomyno commented Dec 12, 2024

TODO: pair with Jacek on this PR.

Copy link

codspeed-hq bot commented Dec 12, 2024

CodSpeed Performance Report

Merging #5083 will not alter performance

Comparing feat/multi-line-comments (15678e9) with main (3872ce4)

Summary

✅ 11 untouched benchmarks

Copy link
Contributor

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.053MiB 2.050MiB 2.667KiB
Postgres (gzip) 822.764KiB 822.099KiB 681.000B
Mysql 2.017MiB 2.014MiB 2.666KiB
Mysql (gzip) 809.151KiB 808.348KiB 822.000B
Sqlite 1.914MiB 1.912MiB 2.650KiB
Sqlite (gzip) 768.837KiB 768.518KiB 327.000B

@jkomyno jkomyno added this to the 6.1.0 milestone Dec 12, 2024
@jkomyno jkomyno merged commit 81600e1 into main Dec 13, 2024
367 checks passed
@jkomyno jkomyno deleted the feat/multi-line-comments branch December 13, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add multi-line / block comments to PSL / schema.prisma file
2 participants