Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driver-adapters): rename one missed span attribute #5086

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Dec 16, 2024

Fixup #5049 and rename one missed span attribute. The tests on the client were updated to expect the new name but the attribute was only updated in one of two places.

Fixup #5049 and rename one
missed span attribute. The tests on the client were updated to expect
the new name but the attribute was only updated in one of two places.
@aqrln aqrln requested a review from a team as a code owner December 16, 2024 12:30
@aqrln aqrln requested review from jacek-prisma and removed request for a team December 16, 2024 12:30
@aqrln aqrln added this to the 6.1.0 milestone Dec 16, 2024
Copy link

codspeed-hq bot commented Dec 16, 2024

CodSpeed Performance Report

Merging #5086 will not alter performance

Comparing fixup-span-name (7e140a4) with main (5b4fe75)

Summary

✅ 11 untouched benchmarks

Copy link
Contributor

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.078MiB 2.078MiB -48.000B
Postgres (gzip) 835.122KiB 835.073KiB 50.000B
Mysql 2.044MiB 2.044MiB -49.000B
Mysql (gzip) 821.668KiB 821.530KiB 142.000B
Sqlite 1.942MiB 1.942MiB -45.000B
Sqlite (gzip) 780.993KiB 781.036KiB -44.000B

@aqrln aqrln merged commit 79c7f7d into main Dec 16, 2024
342 checks passed
@aqrln aqrln deleted the fixup-span-name branch December 16, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants