Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promote tracing to GA #5087

Merged
merged 1 commit into from
Dec 16, 2024
Merged

feat: promote tracing to GA #5087

merged 1 commit into from
Dec 16, 2024

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Dec 16, 2024

@aqrln aqrln requested a review from a team as a code owner December 16, 2024 14:04
@aqrln aqrln requested review from jkomyno and removed request for a team December 16, 2024 14:04
Copy link

codspeed-hq bot commented Dec 16, 2024

CodSpeed Performance Report

Merging #5087 will not alter performance

Comparing tracing-ga (e970078) with main (79c7f7d)

Summary

✅ 11 untouched benchmarks

@aqrln aqrln force-pushed the tracing-ga branch 2 times, most recently from 11c9e84 to fcc1a46 Compare December 16, 2024 14:17
@aqrln aqrln added this to the 6.1.0 milestone Dec 16, 2024
Copy link
Contributor

github-actions bot commented Dec 16, 2024

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.079MiB 2.078MiB 489.000B
Postgres (gzip) 835.577KiB 835.121KiB 467.000B
Mysql 2.044MiB 2.044MiB 490.000B
Mysql (gzip) 821.679KiB 821.668KiB 11.000B
Sqlite 1.942MiB 1.942MiB 489.000B
Sqlite (gzip) 781.242KiB 780.993KiB 255.000B

Comment on lines +399 to +401
if is_tracing_enabled {
url.query_params.statement_cache_size = 0;
}
Copy link
Contributor

@jkomyno jkomyno Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be documented in prisma/docs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with Postgres. These three lines are a poor man's counterpart to #5082.

@jkomyno
Copy link
Contributor

jkomyno commented Dec 16, 2024

D1 tests are failing:

──── TRY 6 STDERR: query-engine-tests::query_engine_tests new::ref_actions::on_update::restrict::one2many_opt::update_many_parent_failure
[D1] Resetting database
[D1] Running database migration script
thread 'new::ref_actions::on_update::restrict::one2many_opt::update_many_parent_failure' panicked at query-engine/connector-test-kit-rs/query-tests-setup/src/lib.rs:288:10:
called Result::unwrap() on an Err value: MigrationCoreError(ConnectorErrorImpl { user_facing_error: None, message: Some("Error migrating with D1 adapter: Server error: Error: missing field enableTracing at line 1 column 9018\n at __wbindgen_throw (file:///home/runner/work/prisma-engines/prisma-engines/query-engine/query-engine-wasm/pkg/sqlite/query_engine_bg.js:856:11)\n at query_engine_wasm.wasm.wasm_bindgen::throw_str::he17ede209d3e6026 (wasm://wasm/query_engine_wasm.wasm-009e465a:wasm-function[5450]:0x1cb59c)\n at query_engine_wasm.wasm.queryengine_new (wasm://wasm/query_engine_wasm.wasm-009e465a:wasm-function[89]:0x29622)\n at new QueryEngine (file:///home/runner/work/prisma-engines/prisma-engines/query-engine/query-engine-wasm/pkg/sqlite/query_engine_bg.js:292:18)\n at initQueryEngine (file:///home/runner/work/prisma-engines/prisma-engines/query-engine/driver-adapters/executor/dist/chunk-B333IA3N.mjs:20:12)\n at async initQe (file:///home/runner/work/prisma-engines/prisma-engines/query-engine/driver-adapters/executor/dist/testd.mjs:625:26)\n at async handleRequest (file:///home/runner/work/prisma-engines/prisma-engines/query-engine/driver-adapters/executor/dist/testd.mjs:503:35)\n at async Interface. (file:///home/runner/work/prisma-engines/prisma-engines/query-engine/driver-adapters/executor/dist/testd.mjs:475:26)"), source: None, context: SpanTrace [] }

@aqrln aqrln merged commit 40232c9 into main Dec 16, 2024
368 checks passed
@aqrln aqrln deleted the tracing-ga branch December 16, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants