This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some things introduced in #4709.
This looks like a big change but it's actually just a few changes solely related to go connections:
Note
The edges now successfully return an array of nodes, but I can't get it to work so that the cursor is returned as well, it's either the cursor or the node (and its fields), but it seems impossible to get both. I know you don't have much resources for the v1 Go client, but let me propose a few options and I'll take care of it:
I say we go for 3 and 4 so that the Go client end-user won't notice anything but working stuff, namely they have access to .Nodes() and .Edges(). This is all non-breaking.
code line where edges/nodes are fetched:
prisma/prisma@4eb62d6#diff-04c0cc2080a3ea69465276562ce0521bR295
cc @matthewmueller, can you please take a look at it?