Preload the application assets and cache connections #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasoncomes
force-pushed
the
jc/embedded-preload
branch
from
48417e9 to
baabf8c
Compare
taylorreece
approved these changes
Mar 26, 2024
bkegley
reviewed
Mar 26, 2024
src/lib/init.ts
Outdated
| * assets (css, js, fonts, etc.) into browser cache. Subsequent | ||
| * calls, use existing connections and cached assets. | ||
| */ | ||
| if (options.preload) { |
There was a problem hiding this comment.
Is there a reason we're making this configurable? Seems like it should just be the behavior of init
There was a problem hiding this comment.
Did it for possible performance issue from the consumer, although this isn't render blocking it does't it does defer the dispatch of the main pages on-load event until after its own on-load event is dispatched.
There was a problem hiding this comment.
Alright. If you think making this configurable is potentially helpful I'm game for it. However, optional properties with true defaults aren't ideal. Can you change this to skipPreload?: boolean?
There was a problem hiding this comment.
Good call, doing now.
jasoncomes
force-pushed
the
jc/embedded-preload
branch
2 times, most recently
from
c48fc6f to
bc155cb
Compare
jasoncomes
force-pushed
the
jc/embedded-preload
branch
from
bc155cb to
de010f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
We need a method to pre-load assets and connections when making calls within the embedded SDK.
Tried Solutions:
dns-prefetch: Unnecessary because DNS resolution to obtain the cached IP address has already been done.preconnect: Establishing apreconnectfrom the top frame origin for resources referenced in the iframe will not function properly due to the differing origins between the top frame and the iframe.preload: This method only preloads specified resources, which is ineffective for our case since our resources are bundled with different hashes. To make this work, we would need to create a remote-fetchable manifest that references these resources. This approach does not seem worthwhile.prerender: Deprecating in Chrome and Edge, and already deprecated in Safari and Firefox.prefetch: Only applicable for same-origin resources.**Solution: **
Develop a publicly accessible
embeddedroute which is initially blank but contains all the necessary assets (css, js, fonts, etc.) for caching. The connections are also shared among iframe origins. I confirmed that the assets are all the hashed the same, as you navigate the application.Lifecycle of the Embedded:
/embedded.