Add support for connection avatar icons #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkegley
commented
Oct 25, 2024
| @@ -1,4 +1,4 @@ | |||
| import { ComponentDefinition as ComponentDefinitionTemplate } from "@prismatic-io/spectral"; | |||
| import { Component as ComponentDefinitionTemplate } from "@prismatic-io/spectral/dist/serverTypes"; | |||
There was a problem hiding this comment.
This was errantly referencing the ComponentDefinition prior to running through the convert layer. prism handles the result of spectral's convertComponent/convertIntegration.
pattra
reviewed
Oct 25, 2024
bkegley
force-pushed
the
add-connection-avatar-url
branch
2 times, most recently
from
f869c21 to
5afa760
Compare
bkegley
force-pushed
the
add-connection-avatar-url
branch
from
5afa760 to
6dbd239
Compare
pattra
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.