Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODIFY intance/create and intance/update files to add version flag as… #21

Merged
merged 6 commits into from
May 18, 2023

Conversation

gtemitheo
Copy link
Contributor

… an alias for integration, and to add version and latestVersion flags respectively

  • create_instance
    • Exposed a new flag called version
    • Change the integration flag to non required
    • Created a condition that checks if either field was supplied
      • If not supplied an error is thrown
    • Added a new variable that used the first non-None value
    • Set the variable as the default for the integration variable
  • update_instance
    • Added new flag for version and for latestVersion, both non-required
    • Added a variable for version and implemented the call in graphql
    • ?? How can I get the latest version in order to supply if the flag is provided?

[sc-11999]

… an alias for integration, and to add version and latestVersion flags respectively
@gtemitheo gtemitheo requested a review from hipplej May 18, 2023 17:28
Copy link
Member

@hipplej hipplej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really minor feedback. I think the only blocking issue is that you'll need to bump the version in package.json to 4.6.3. Then we can get it published!

src/commands/instances/create.ts Outdated Show resolved Hide resolved
src/commands/instances/create.ts Outdated Show resolved Hide resolved
Copy link
Member

@hipplej hipplej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor nit but otherwise LGTM. :shipit:

src/commands/instances/create.ts Outdated Show resolved Hide resolved
@gtemitheo gtemitheo merged commit 22bcf3a into main May 18, 2023
@gtemitheo gtemitheo deleted the tt/sc-11999/modify_update_instance branch May 18, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants