This repository has been archived by the owner on May 20, 2024. It is now read-only.
Improve isomorphism #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
controversial
added a commit
to controversial/luk.ke
that referenced
this pull request
Mar 21, 2020
bundled prismic-dom files referenced "window," which broke server-side rendering. I updated the webpack config to use "this" over "window." For details, see: - controversial/prismic-dom@c4e8556 - prismicio/prismic-dom#39
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates webpack config to use "
this" over "window" in generated files. This allows the generated files indistto be usable in both browsers and Node.js.Previously, some server-side environments could generate "window is not defined" errors as a result of requiring the dist files bundled with prismic-dom, since the webpack-generated dist files referenced window specifically, which is usually only defined in browser environments.