Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update build output format #28

Closed
wants to merge 2 commits into from
Closed

Conversation

xrutayisire
Copy link
Collaborator

Resolves: N/A

Description

  • We wanted to use this package in an Obelix PR, and it started to fail in the CI.

New items from Filip via Slack

I started to take a look at it, and was able to solve it like this. Happy to discuss this change.

Checklist

  • A comprehensive Linear ticket, providing sufficient context and details to facilitate the review of the PR, is linked to the PR.
  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

How to QA 1

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment.

@xrutayisire xrutayisire changed the title Xru/fix usage obelix chore: update build output format Dec 16, 2024
Copy link

size-limit report 📦

Path Size
dist/index.js 11.11 KB (-0.42% 🔽)
dist/index.cjs 14.94 KB (+3.68% 🔺)

@angeloashmore angeloashmore mentioned this pull request Dec 16, 2024
4 tasks
@angeloashmore
Copy link
Member

Superseded by #29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants