chore: instance columns for poseidon bench #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPerezz
approved these changes
Dec 10, 2022
There was a problem hiding this comment.
LGTM!! I highly suggest to push this into upstream too since this TODO is original from upstream. See: https://github.com/zcash/halo2/blob/7239a02ea34008b8973d742b3e918bbfbc01b75e/halo2_gadgets/benches/poseidon.rs#L31
Thanks in advance!!
iquerejeta
pushed a commit
to input-output-hk/halo2
that referenced
this pull request
May 8, 2024
…-hk/dev-feature/zk-folding Add Zero Knowledge folding implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a small lingering todo in
halo2_gadgets/benches/poseidon.rsto move the outputs from aValueto an instance column. This PR does just that !HashCircuit.output, which is of typeValue<Fp>, withMyConfig.expectedof typeColumn<Instance>.clippy