Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generic array casts #59

Merged
merged 7 commits into from
Sep 13, 2023
Merged

feat: generic array casts #59

merged 7 commits into from
Sep 13, 2023

Conversation

sinui0
Copy link
Collaborator

@sinui0 sinui0 commented Sep 11, 2023

This PR adds helper methods for converting variations of Block into GenericArray<u8, U16> from the generic-array crate. This reduces copies in a few places and lets us take better advantage of instruction-level parallelism provided by RustCrypto crates.

This was referenced Sep 11, 2023
Copy link
Member

@th4s th4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mpz-core/src/block.rs Show resolved Hide resolved
mpz-core/src/block.rs Show resolved Hide resolved
@sinui0 sinui0 mentioned this pull request Sep 13, 2023
Copy link
Collaborator

@themighty1 themighty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, some code comments

mpz-core/src/aes.rs Show resolved Hide resolved
mpz-core/src/aes.rs Show resolved Hide resolved
mpz-core/src/aes.rs Outdated Show resolved Hide resolved
@sinui0 sinui0 merged commit e4f23f4 into dev Sep 13, 2023
2 checks passed
@sinui0 sinui0 deleted the feature/generic_array_casts branch September 13, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants