Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clmul aarch64 #74

Merged
merged 5 commits into from
Oct 9, 2023
Merged

fix: clmul aarch64 #74

merged 5 commits into from
Oct 9, 2023

Conversation

sinui0
Copy link
Collaborator

@sinui0 sinui0 commented Oct 5, 2023

This PR reorganizes some things and brings the clmul crate more inline with the original polyval crate.

Changes

  • Removes armv8 and force-soft features in favor of using RUSTFLAGS
  • Reorganizes modules to match polyval layout

@sinui0 sinui0 requested a review from themighty1 October 5, 2023 20:34
themighty1
themighty1 requested changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@themighty1 themighty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, a fix is needed

clmul/src/backend/autodetect.rs Show resolved Hide resolved
clmul/src/backend/autodetect.rs Outdated Show resolved Hide resolved
clmul/Cargo.toml Show resolved Hide resolved
@sinui0 sinui0 mentioned this pull request Oct 7, 2023
Merged
@themighty1 themighty1 self-requested a review October 9, 2023 06:00
themighty1
themighty1 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@themighty1 themighty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sinui0 sinui0 merged commit 59e78e0 into dev Oct 9, 2023
3 checks passed
@sinui0 sinui0 deleted the fix/clmul-aarch branch October 9, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themighty1 themighty1 themighty1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sinui0 @themighty1