Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add dts plugin to roll-up definition files #320

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix: add dts plugin to roll-up definition files #320

merged 1 commit into from
Sep 13, 2024

Conversation

cedoor
Copy link
Member

@cedoor cedoor commented Sep 11, 2024

Description

This PR integrates rollup-plugin-dts to roll-up definition files for each package and fix #319.

Related Issue(s)

Fixes #319

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn style without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@sripwoud sripwoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forked the repro repo mentioned in the issue to test importing all packages.
I can import them all successfully except @zk-kit/baby-jujub
I don't understand why, I don't see anything different in the config of that package

See sripwoud/esm-import-repro#1

Copy link
Member

@sripwoud sripwoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robknight
Copy link

Works for me!

@cedoor cedoor merged commit 500d240 into main Sep 13, 2024
2 checks passed
@cedoor cedoor deleted the fix/exports branch September 13, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-ESM-compliant exports break for certain downstream consumers
4 participants