fix(eddsa-poseidon): Check size of the message parameter #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it doesnt exceed 32 bytes. re privacy-scaling-explorations#190
cedoor
reviewed
Oct 25, 2024
There was a problem hiding this comment.
Hey @hannahredler, thanks for this PR. I just realized it's better to wait for #318 before merging this.
|
Hey @cedoor ah yes i just saw the other PR. Happy to adjust this PR as necessary once the other is finished. |
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checks the message parameter, to ensure it doesn't exceed 32 bytes, as this is required for poseidon.
Related Issue(s)
#190
Checklist
yarn stylewithout getting any errors