Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typo in "Deleted Method" #356

Closed
wants to merge 1 commit into from

Conversation

mdqst
Copy link

@mdqst mdqst commented Dec 4, 2024

Снимок экрана 2024-12-04 в 19 28 07

This phrasing is incorrect because "deleted" refers to a state, not the action of deleting. In programming, methods are named after the actions they perform, so the correct term is "delete method."

The updated phrasing now reads:

"The Lean Merkle tree is excluded because it does not have the delete method implemented."

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn style without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@mdqst mdqst requested review from cedoor and sripwoud as code owners December 4, 2024 16:29
@sripwoud
Copy link
Member

sripwoud commented Dec 4, 2024

there is indeed a typo, but your PR does not fix it properly (the PR does not reflect exactly the change mentioned in the desc)

Copy link
Member

@sripwoud sripwoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the delete" instead?

@sripwoud
Copy link
Member

sripwoud commented Dec 4, 2024

@cedoor AI submitted PR?

@mdqst
Copy link
Author

mdqst commented Dec 4, 2024

@cedoor AI submitted PR?

No, of course, I am a real person.

@mdqst mdqst changed the title Fix Typo in "Delete Method" Fix Typo in "Deleted Method" Dec 4, 2024
@mdqst
Copy link
Author

mdqst commented Dec 4, 2024

there is indeed a typo, but your PR does not fix it properly (the PR does not reflect exactly the change mentioned in the desc)

I corrected the description.

@mdqst mdqst requested a review from sripwoud December 4, 2024 16:46
@sripwoud
Copy link
Member

sripwoud commented Dec 4, 2024

please update the PR code change too, not just the PR description

@mdqst
Copy link
Author

mdqst commented Dec 4, 2024

please update the PR code change too, not just the PR description

its done

Снимок экрана 2024-12-04 в 19 54 14

@@ -45,7 +45,7 @@ The benchmark includes the following tests for each Merkle Tree implementation:
2. Generate Proofs: Measures the performance of generating Merkle proofs.
3. Verify Proofs: Measures how quickly the generated proofs can be verified.
4. Update Leaves: Measures how quickly the leaves can be updated.
5. Delete Leaves: Measures how quickly the leaves can be deleted. The Lean Merkle tree is excluded because it does not have deleted method implemented.
5. Delete Leaves: Measures how quickly the leaves can be deleted. The Lean Merkle tree is excluded because it does not have delete method implemented.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
5. Delete Leaves: Measures how quickly the leaves can be deleted. The Lean Merkle tree is excluded because it does not have delete method implemented.
5. Delete Leaves: Measures how quickly the leaves can be deleted. The Lean Merkle tree is excluded because it does not have the `delete` method implemented.

@sripwoud sripwoud closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants