-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Typo in "Deleted Method" #356
Conversation
there is indeed a typo, but your PR does not fix it properly (the PR does not reflect exactly the change mentioned in the desc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"the delete
" instead?
@cedoor AI submitted PR? |
No, of course, I am a real person. |
I corrected the description. |
please update the PR code change too, not just the PR description |
@@ -45,7 +45,7 @@ The benchmark includes the following tests for each Merkle Tree implementation: | |||
2. Generate Proofs: Measures the performance of generating Merkle proofs. | |||
3. Verify Proofs: Measures how quickly the generated proofs can be verified. | |||
4. Update Leaves: Measures how quickly the leaves can be updated. | |||
5. Delete Leaves: Measures how quickly the leaves can be deleted. The Lean Merkle tree is excluded because it does not have deleted method implemented. | |||
5. Delete Leaves: Measures how quickly the leaves can be deleted. The Lean Merkle tree is excluded because it does not have delete method implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5. Delete Leaves: Measures how quickly the leaves can be deleted. The Lean Merkle tree is excluded because it does not have delete method implemented. | |
5. Delete Leaves: Measures how quickly the leaves can be deleted. The Lean Merkle tree is excluded because it does not have the `delete` method implemented. |
This phrasing is incorrect because "deleted" refers to a state, not the action of deleting. In programming, methods are named after the actions they perform, so the correct term is "delete method."
The updated phrasing now reads:
Checklist
yarn style
without getting any errors