Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Integration tests compare permutations of proofs to check for variadic circuits #1480

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

leolara
Copy link
Contributor

@leolara leolara commented Jun 16, 2023

Description

Integration tests compare permutations of proofs to check for variadic circuits

Issue Link

[link issue here]

Type of change

  • New feature (non-breaking change which adds functionality)

Contents

  • as said

Rationale

Trivial

How Has This Been Tested?

Run integration test in PR

@github-actions github-actions bot added the crate-integration-tests Issues related to the integration-tests workspace member label Jun 16, 2023
Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This was short :D

Copy link
Member

@hero78119 hero78119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, except a small coding style

@leolara leolara enabled auto-merge June 16, 2023 08:15
@leolara
Copy link
Contributor Author

leolara commented Jun 16, 2023

comment by @hero78119 Done

@leolara leolara added this pull request to the merge queue Jun 16, 2023
Copy link
Member

@hero78119 hero78119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Merged via the queue into main with commit b615622 Jun 16, 2023
19 checks passed
@leolara leolara deleted the leo/permutations branch June 16, 2023 10:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
crate-integration-tests Issues related to the integration-tests workspace member run-integration-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests compare permutations of proofs to check for variadic circuits
3 participants