Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Add precompile contracts' addresses to the access list #1640

Merged
merged 6 commits into from
Oct 5, 2023
Merged

Add precompile contracts' addresses to the access list #1640

merged 6 commits into from
Oct 5, 2023

Conversation

ChihChengLiang
Copy link
Collaborator

@ChihChengLiang ChihChengLiang commented Oct 3, 2023 •
edited
Loading

Description

We upstream scroll's precompile handling in bus mapping so that the EVM circuit warms the precompile addresses at the beginning of the transaction.

Issue Link

#1626

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Content

  • Warm precompile addresses
  • Fix some minor issues in StepRws offset and the Rws debugging messages.

@github-actions github-actions bot added crate-bus-mapping Issues related to the bus-mapping workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member labels Oct 3, 2023
@ChihChengLiang ChihChengLiang linked an issue Oct 3, 2023 that may be closed by this pull request
bug: precompile should be warm in begin_tx #1626
Closed
@ChihChengLiang ChihChengLiang marked this pull request as ready for review October 3, 2023 11:57
@adria0 adria0 self-requested a review October 3, 2023 12:21
adria0
adria0 reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@adria0 adria0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

bus-mapping/src/evm/opcodes/begin_end_tx.rs Outdated Show resolved Hide resolved
zkevm-circuits/src/evm_circuit/util.rs Outdated Show resolved Hide resolved
zkevm-circuits/src/evm_circuit/util.rs Outdated Show resolved Hide resolved
@KimiWu123 KimiWu123 self-requested a review October 5, 2023 02:10
KimiWu123
KimiWu123 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@KimiWu123 KimiWu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bus-mapping/src/evm/opcodes/begin_end_tx.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot added the crate-eth-types Issues related to the eth-types workspace member label Oct 5, 2023
@ChihChengLiang ChihChengLiang added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit ed866f0 Oct 5, 2023
13 checks passed
@ChihChengLiang ChihChengLiang deleted the add-precompile-to-warm-access-list branch October 5, 2023 06:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adria0 adria0 adria0 approved these changes

@KimiWu123 KimiWu123 KimiWu123 approved these changes

Assignees
No one assigned
Labels
crate-bus-mapping Issues related to the bus-mapping workspace member crate-eth-types Issues related to the eth-types workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: precompile should be warm in begin_tx
3 participants
@ChihChengLiang @adria0 @KimiWu123