Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Integrating FFT & Memory Optimization #1655

Closed

Conversation

CeciliaZ030
Copy link
Contributor

From Einar
taikoxyz/halo2/pull/6
taikoxyz/halo2/pull/4

  • snark-verifier still depends on PSE's halo2
  • halo2wrong as well
    Neet to fork these repo and change the dependency.

dantaik and others added 30 commits May 20, 2023 11:39
* feat: add anchor transaction circuit

* chore: improve comment

* fix: clippy complain

* feat: add tests

* chore: update method signature

* fix: clippy

* feat: support meta hash

* chore: improve the comment

* chore: use LookupTable for readable

* improve: readable

* fix: query columns cross different regions

* fix: sign verify test case

* fix: add r == GX2 test case

* chore: clippy complain

* Some misc small improvements

* improve: code clean

* fix(IsEqual): alloc value_inv with closure

* fix: clippy complain

* Revert some formatting only changes

* Simplify byte lookup

---------

Co-authored-by: Brechtpd <Brechtp.devos@gmail.com>
…it (#120)

* Use Taiko url

* Update

* Add tests/taiko_circuits.rs

* Add tests/taiko_circuit_input_builder.rs

* Revert changes

* Update

* Update

* Refactor

* Update

* Update

* Update

* Update keccak_inputs in block_convert

* Update

* Update
* Recursion PoC

* Remove unnecessary proof

* fix: use block_table as lookup

* feat: add taiko_super_circuit for our recursion proof

* reset super_circuit

* feat: benchmarks/super_circuit use taiko super circuit

* fix: clippy

* fix: benchmark

* fix: remove unused selectors

* use root circuit to pass instances

* make root circuit support multi sub-circuits

* use new pcd aggregation circuit

* add N->1 aggregation testcase

* add new circuit file

* make PCDAggregationCircuit generic for both GWC & SHPLONK

* make PCDAggregationCircuit generic for both GWC & SHPLONK

* Update zkevm-circuits/src/witness/block.rs

Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>

* update lib

* fix name

* fix: remove unused selectors

* feat: add anchor circuit into super circuit

* fix: load pi_table

* rename pcd aggregation circuit

* fix: super circuit test cases

* fix: benchmark

* move test in taiko super circuit to test.rs

* remove deprecated function and fix test

* clean compile warnings

* fix(test): test-all relevant to taiko

* feat: export the metahash

* chore: move golden touch wallet into test

* fix: use protocol instance in block witness

* Fix 2tx test issue

* Re-enable PSE PI tests that were temporarily disabled

* Update zkevm-circuits/src/root_circuit/taiko_aggregation.rs

Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>

* fix: pi-circuit tests

* fix: ignore the anchor tx's fee

* fix: anchor tx without fee

* fix: each params will be up to u256

* fix: gas price non zero

* fix(anchor): calldata with fixed 32B

* feat: add anchor flag and support multi V

* fix: anchor method signature changed

* fix(anchor): error randomness

* fix: clippy complain

* Fix make test-all + Feedback changes

---------

Co-authored-by: johntaiko <john@taiko.xyz>
Co-authored-by: smtmfft <smtm@taiko.xyz>
Co-authored-by: smtmfft <99081233+smtmfft@users.noreply.github.com>
This commit introduces the support for precompiled contracts. For more
information, check the appendix E of the Ethereum Yellow Paper.

It is a simplified version of the identity precompile PR of PSE. It
strips the implementation of the identity precompile variant, leaving
only the skeleton for the lookup table calls.

[Ethereum Yellow Paper](https://ethereum.github.io/yellowpaper/paper.pdf)
[Identity (dataCopy) precompile privacy-scaling-explorations#1396](privacy-scaling-explorations#1396)
Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>
Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>
Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>
smtmfft and others added 18 commits September 21, 2023 16:33
Support eip-1559 and Evm-circuit in aggregation
Signed-off-by: smtmfft <smtm@taiko.xyz>
Signed-off-by: smtmfft <smtm@taiko.xyz>
Signed-off-by: smtmfft <smtm@taiko.xyz>
Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>
Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>
Signed-off-by: smtmfft <smtm@taiko.xyz>
Signed-off-by: smtmfft <smtm@taiko.xyz>
Signed-off-by: smtmfft <smtm@taiko.xyz>
@github-actions github-actions bot added crate-bus-mapping Issues related to the bus-mapping workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member crate-external-tracer Issues related to the external-tracer workspace member CI Issues related to the Continuous Integration mechanisms of the repository. crate-mock Issues related to the mock workspace member T-bench Type: benchmark improvements crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member crate-integration-tests Issues related to the integration-tests workspace member crate-eth-types Issues related to the eth-types workspace member crate-geth-utils Issues related to the geth-utils workspace member crate-gadgets Issues related to the gadgets workspace member labels Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI Issues related to the Continuous Integration mechanisms of the repository. crate-bus-mapping Issues related to the bus-mapping workspace member crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member crate-eth-types Issues related to the eth-types workspace member crate-external-tracer Issues related to the external-tracer workspace member crate-gadgets Issues related to the gadgets workspace member crate-geth-utils Issues related to the geth-utils workspace member crate-integration-tests Issues related to the integration-tests workspace member crate-mock Issues related to the mock workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member T-bench Type: benchmark improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants