Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

[proof chunk] [verifying unittest] evm circuit begin/endChunk implementation in single chunk - part 2 #1660

Closed
wants to merge 19 commits into from
Closed

[proof chunk] [verifying unittest] evm circuit begin/endChunk implementation in single chunk - part 2 #1660

wants to merge 19 commits into from

Conversation

hero78119
Copy link
Member

@hero78119 hero78119 commented Oct 16, 2023 •
edited
Loading

Description

PR is following up the changes after #1641

Issue Link

#1601

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contents

  • add begin/end chunk virtual step, and enable it in single chunk logic
  • define chunk context to be used later
  • ...

@hero78119 hero78119 marked this pull request as draft October 16, 2023 08:04
@github-actions github-actions bot added crate-bus-mapping Issues related to the bus-mapping workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member T-bench Type: benchmark improvements crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member crate-gadgets Issues related to the gadgets workspace member labels Oct 16, 2023
@hero78119 hero78119 changed the title [proof chunk] evm circuit begin end chunk implementation in single chunk - part 2 [proof chunk] evm circuit begin/endChunk implementation in single chunk - part 2 Oct 16, 2023
@hero78119 hero78119 marked this pull request as ready for review October 17, 2023 08:04
@hero78119 hero78119 changed the title [proof chunk] evm circuit begin/endChunk implementation in single chunk - part 2 [proof chunk] [verifying unittest] evm circuit begin/endChunk implementation in single chunk - part 2 Oct 17, 2023
@hero78119 hero78119 closed this Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
crate-bus-mapping Issues related to the bus-mapping workspace member crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member crate-gadgets Issues related to the gadgets workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member T-bench Type: benchmark improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hero78119