This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
add error pruning on step_first/step_last to avoid use against lookup #1664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This works
However it doesnt works on any lookup wrap by step, e.g.
The reason is because lookup constraints expression not including location selector when query lookup cell.
https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/main/zkevm-circuits/src/evm_circuit/util/constraint_builder.rs#L1489-L1496
While the location selector are created in execution.rs at later phase
zkevm-circuits/zkevm-circuits/src/evm_circuit/execution.rs
Lines 731 to 757 in 09651d4
when converting constraints to custom gate. This works for normal constraints but not works for lookup expression.
This PR add error pruning step to avoid lookup usage against step_first/step_last
Type of change