This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
[WIP] MPT inserted ext node #914
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to be compatible with hash RLC computation
…kup fix in branch_rlc
… enable special case when short is branch)
|
@miha-stopar is this PR still being worked on? Can we close it if it isn't? |
@ChihChengLiang I am porting it to the refactored MPT code, so I am still looking at it. Can it remain open for a bit more? |
|
Sounds good. Let's keep it open. |
GopherJ
pushed a commit
to dompute/zkevm-circuits
that referenced
this pull request
Sep 13, 2023
* add prestate tracer * use trace_block_prestate_by_hash in get_state_accesses * ignore test_print_circuits_size * fix clippy * fix --------- Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>
|
We're keeping this PR for reference but the plan is to port the code to the current MPT implementation via #1563. After this is done we'll close this PR. |
|
Closed in favour of #1685. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers the case when extension node is inserted at the place of the existing extension node. The old extension node gets modified - it now has a different number of nibbles.
Some more info here: privacy-scaling-explorations/zkevm-specs#268