This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
fix: Mock Challenges with different values
#930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Comment on this pull request with |
github-actions
bot
added
the
crate-zkevm-circuits
han0110
approved these changes
Nov 24, 2022
|
@han0110 will do so then. It just annoys me a lot that we can't just take one and add X to it to det the second one.. But will just require 2 and that's all! Thanks! |
As mentioned in #926, the `Challenges::mock` function was not adding different values for the `Challenges`. Therefore, a new function has been added that allows mocking by passing two different values (one per each challenge). This allows to keep the API we previously had and also, reduce the need to send always 2 values when only 1 can be passed. Resolves: #926
CPerezz
force-pushed
the
fix_challenges_mocking
branch
from
45456b5
to
7991cee
Compare
|
Just rebased. Will merge as soon as CI passes. |
ed255
approved these changes
Nov 24, 2022
The only place where the two are needed is Keccak circuit AFAIK. In the rest of places, I left the same code/config as we had before. |
RainFallsSilent
pushed a commit
to dompute/zkevm-circuits
that referenced
this pull request
Sep 14, 2023
…ions#930) * wip: preliminary work sig circuit/lookp * feat: handle panics and edge cases in sig circuit * fix: handle v not boolean * fix: fq modulus not assigned and bus-mapping handle overflowing r/s * fix: sig_v handle invalid values (lookup) and is_valid dev_load fix * refactor (review comment) * fix: no sig table lookup for invalid sig_v * remove wrong test case (assertion fail)
KimiWu123
pushed a commit
that referenced
this pull request
Dec 25, 2023
* wip: preliminary work sig circuit/lookp * feat: handle panics and edge cases in sig circuit * fix: handle v not boolean * fix: fq modulus not assigned and bus-mapping handle overflowing r/s * fix: sig_v handle invalid values (lookup) and is_valid dev_load fix * refactor (review comment) * fix: no sig table lookup for invalid sig_v * remove wrong test case (assertion fail)
KimiWu123
pushed a commit
that referenced
this pull request
Dec 28, 2023
* wip: preliminary work sig circuit/lookp * feat: handle panics and edge cases in sig circuit * fix: handle v not boolean * fix: fq modulus not assigned and bus-mapping handle overflowing r/s * fix: sig_v handle invalid values (lookup) and is_valid dev_load fix * refactor (review comment) * fix: no sig table lookup for invalid sig_v * remove wrong test case (assertion fail)
KimiWu123
pushed a commit
that referenced
this pull request
Jan 4, 2024
* wip: preliminary work sig circuit/lookp * feat: handle panics and edge cases in sig circuit * fix: handle v not boolean * fix: fq modulus not assigned and bus-mapping handle overflowing r/s * fix: sig_v handle invalid values (lookup) and is_valid dev_load fix * refactor (review comment) * fix: no sig table lookup for invalid sig_v * remove wrong test case (assertion fail)
KimiWu123
pushed a commit
that referenced
this pull request
Jan 26, 2024
* wip: preliminary work sig circuit/lookp * feat: handle panics and edge cases in sig circuit * fix: handle v not boolean * fix: fq modulus not assigned and bus-mapping handle overflowing r/s * fix: sig_v handle invalid values (lookup) and is_valid dev_load fix * refactor (review comment) * fix: no sig table lookup for invalid sig_v * remove wrong test case (assertion fail)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #926, the
Challenges::mockfunction was not adding different values for theChallenges. Therefore, a new function has been added that allows mocking by passing two different values (one per each challenge).This allows to keep the API we previously had and also, reduce the need to send always 2 values when only 1 can be passed.
Resolves: #926
I considered to do a
Trait-based approach by ussingAdd<Output=Self>butExpression<F>does not implement this trait. Same happens forChallenge(the one in Halo2).Therefore, the easiest way to not break the current API and also, not ask for 2 values when we don't need them to be different (everywhere minus Keccak) is to introduce a new function.