This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Add SWAPX spec #48
Merged
Add SWAPX spec #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miha-stopar
reviewed
Oct 13, 2021
specs/opcode/0x90_swapx.md
Outdated
| @@ -0,0 +1,24 @@ | |||
| # SWAPX op code | |||
There was a problem hiding this comment.
I think it's good if we make the names of opcode files consistent - we first had it 26BYTE.md and 50POP.md, so I suggest having 90SWAPX.md here.
specs/opcode/0x90_swapx.md
Outdated
| @@ -0,0 +1,24 @@ | |||
| # SWAPX op code | |||
| ## Procedure | |||
| swapx represents op codes of swap1....swap16. which swaps the top of the stack with the 'x+1'th last element. for exmaple, SWAP3 means swaping the top of the stack with the 4th last element | |||
There was a problem hiding this comment.
There are some typos like "exmaple" and capitalisation of letters.
specs/opcode/0x90_swapx.md
Outdated
|
|
||
| ## Exceptions | ||
| 1. gas out: remaining gas is not enough | ||
| 2. stack underflow: when stack length is less than swap position 'x + 1', i.e stack have 3 elements but swap4 or more |
There was a problem hiding this comment.
Perhaps "i.e stack have 3 elements but swap4 or more" -> "i.e stack have 3 elements but the op is swap3, swap4, ..., swap16.".
There was a problem hiding this comment.
should be more clear & updated
miha-stopar
approved these changes
Oct 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.