-
Notifications
You must be signed in to change notification settings - Fork 272
Entrypoint for EVM circuit and specification for BEGIN_TX
#52
Entrypoint for EVM circuit and specification for BEGIN_TX
#52
Conversation
c574ea8
to
98da8a7
Compare
CALL
55acc27
to
75d07fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concern is that the allocations
in each Step
is quite difficult to write for the test cases in the current way. For a stack push/pop, you need to manually set the lookup entry. Is it possible that we could mimic the approach in the circuit repo that separates the execution steps from the bus mapping lookup?
CALL
CALL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not give a thorough look, just reading through the previous review discussions. If there's nothing more to add to this PR, we can merge and unblock the future PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
CALL
BEGIN_TX
3262b4b
to
07a56b3
Compare
…structed when is_persistent
811d866
to
0e5151d
Compare
Merge for unblocking further PRs. |
This PR aims to:
verify_steps
to better describe EVM circuit.keccak256_table
).BEGIN_TX
to verify the beginning of a transaction.ADD
andPUSH
using newly introducedInstruction
as sample code.is_code
annotation forJUMP*
#66 into consideration inbytecode_table
for further implementation.Some changes have been made including:
global_counter
is renamed torw_counter
cause only writable data are time-aware.ExecutionResult
for all possible cases.Instruciton
to simulate both verifier (constrain some relation) and prover (calculate some non-qudratic relation).