This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 272
Spec for op jumpdest #58
Merged
han0110
merged 5 commits into
privacy-scaling-explorations:master
from
scroll-tech:op_jumpdest
Nov 5, 2021
Merged
Spec for op jumpdest #58
han0110
merged 5 commits into
privacy-scaling-explorations:master
from
scroll-tech:op_jumpdest
Nov 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
han0110
reviewed
Oct 29, 2021
ed255
reviewed
Oct 29, 2021
fix typo Co-authored-by: Eduard S. <eduardsanou@posteo.net>
ChihChengLiang
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with some nitpicks on text.
han0110
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
format style as comment Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com>
spartucus
added a commit
to Sin7Y/zkevm-specs
that referenced
this pull request
Nov 5, 2021
Spec for op jumpdest (privacy-scaling-explorations#58)
spartucus
pushed a commit
to Sin7Y/zkevm-specs
that referenced
this pull request
Nov 9, 2021
* add jumpdest spec * fix formats * minor change * Update specs/opcode/5BJUMPDEST.md fix typo Co-authored-by: Eduard S. <eduardsanou@posteo.net> * Update specs/opcode/5BJUMPDEST.md format style as comment Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com> Co-authored-by: Dream Wu <wwuwwei@126.com> Co-authored-by: Eduard S. <eduardsanou@posteo.net> Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com> Spec for op jumpdest (privacy-scaling-explorations#58) * add jumpdest spec * fix formats * minor change * Update specs/opcode/5BJUMPDEST.md fix typo Co-authored-by: Eduard S. <eduardsanou@posteo.net> * Update specs/opcode/5BJUMPDEST.md format style as comment Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com> Co-authored-by: Dream Wu <wwuwwei@126.com> Co-authored-by: Eduard S. <eduardsanou@posteo.net> Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com> Spec for op jumpdest (privacy-scaling-explorations#58) * add jumpdest spec * fix formats * minor change * Update specs/opcode/5BJUMPDEST.md fix typo Co-authored-by: Eduard S. <eduardsanou@posteo.net> * Update specs/opcode/5BJUMPDEST.md format style as comment Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com> Co-authored-by: Dream Wu <wwuwwei@126.com> Co-authored-by: Eduard S. <eduardsanou@posteo.net> Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com>
ChihChengLiang
added a commit
that referenced
this pull request
Dec 8, 2021
* ignore build directory * Add MSIZE spec * Add more details for MSIZE spec * Spec for op jumpdest (#58) * add jumpdest spec * fix formats * minor change * Update specs/opcode/5BJUMPDEST.md fix typo Co-authored-by: Eduard S. <eduardsanou@posteo.net> * Update specs/opcode/5BJUMPDEST.md format style as comment Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com> Co-authored-by: Dream Wu <wwuwwei@126.com> Co-authored-by: Eduard S. <eduardsanou@posteo.net> Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com> Spec for op jumpdest (#58) * add jumpdest spec * fix formats * minor change * Update specs/opcode/5BJUMPDEST.md fix typo Co-authored-by: Eduard S. <eduardsanou@posteo.net> * Update specs/opcode/5BJUMPDEST.md format style as comment Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com> Co-authored-by: Dream Wu <wwuwwei@126.com> Co-authored-by: Eduard S. <eduardsanou@posteo.net> Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com> Spec for op jumpdest (#58) * add jumpdest spec * fix formats * minor change * Update specs/opcode/5BJUMPDEST.md fix typo Co-authored-by: Eduard S. <eduardsanou@posteo.net> * Update specs/opcode/5BJUMPDEST.md format style as comment Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com> Co-authored-by: Dream Wu <wwuwwei@126.com> Co-authored-by: Eduard S. <eduardsanou@posteo.net> Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com> * refactor with review * fmt code Co-authored-by: Scroll Dev <dev@scroll.tech> Co-authored-by: Dream Wu <wwuwwei@126.com> Co-authored-by: Eduard S. <eduardsanou@posteo.net> Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.