Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove First-Party Sets from CHIPS design #44

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Remove First-Party Sets from CHIPS design #44

merged 1 commit into from
Jun 22, 2022

Conversation

DCtheTall
Copy link
Collaborator

No description provided.

@krgovind krgovind mentioned this pull request Jun 21, 2022
Closed
1 task
krgovind
krgovind approved these changes Jun 22, 2022
View reviewed changes
Copy link
Collaborator

@krgovind krgovind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change, Dylan! Please port these details over to the FPS repo when you have a chance, but we can merge this in in the meantime.

@DCtheTall DCtheTall merged commit 14d7404 into main Jun 22, 2022
@DCtheTall DCtheTall deleted the rm-fps branch June 22, 2022 20:20
@johannhof johannhof mentioned this pull request Nov 4, 2022
Closed
1 task
aarongable pushed a commit to chromium/chromium that referenced this pull request Nov 7, 2022
@DCtheTall
Remove fps_owner_site argument from
3997fd4 
CookiePartitionKey::FromNetworkIsolationKey

This will completely remove partitioned cookies' integration with
First-Party Sets.

We removed FPS from the CHIPS proposal at the request of the PrivacyCG in privacycg/CHIPS#44

Most of the work removing the integration occurred in https://crrev.com/c/3909753, but this part of the integration was accidentally omitted.

Bug: 1225444
Change-Id: I34b795152464facf72a9fbc5bc6174c6162a7793
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4008478
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/main@{#1068103}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krgovind krgovind krgovind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DCtheTall @krgovind